#2597: Update vim-7.2-fixes-5.patch
---------------------+------------------------------------------------------
 Reporter:  kratz00  |       Owner:  lfs-b...@…                   
     Type:  task     |      Status:  new                          
 Priority:  normal   |   Milestone:  6.7                          
Component:  Book     |     Version:  SVN                          
 Severity:  normal   |    Keywords:                               
---------------------+------------------------------------------------------

Comment(by matt...@…):

 I thought I remembered someone saying that the patches available on the
 Vim site were effectively their VCS, i.e. taking their patches & applying
 them in the book is equivalent to doing an svn/git checkout of trunk.  So,
 we may in actual fact want to drop the patch entirely.  I can't find the
 email chain that discussed this at the moment.

 Looking at
 
http://vim.svn.sourceforge.net/viewvc/vim/vim7/src/version.c?revision=1780&view=markup
 it looks like by picking up the latest patch, 382, we'd actually be ahead
 of what's even committed in their SVN repo (376).

 My proposal would therefore be to drop the patch entirely.

 As to kratz00's suggestion - one of our quality gates is that the book
 still builds a functioning system prior to each commit.  I already have a
 script that generates a consolidated Vim patch based on all of upstreams
 patches, so that bit's not too bad at all.  It's the building of a full
 system just to test that upstream's latest development changes haven't
 broken anything that would take time, which I'm sure is better spent
 elsewhere.

-- 
Ticket URL: <http://wiki.linuxfromscratch.org/lfs/ticket/2597#comment:3>
LFS Trac <http://wiki.linuxfromscratch.org/lfs/>
Linux From Scratch: Your Distro, Your Rules.
-- 
http://linuxfromscratch.org/mailman/listinfo/lfs-book
FAQ: http://www.linuxfromscratch.org/lfs/faq.html
Unsubscribe: See the above information page

Reply via email to