Archaic wrote:
The suppress_hostname patch in BLFS broke with the new
suppress_uptime_kill_su patch which prompted me to see why. The reason
was obvious and the workaround simple, but while looking through the new
patch, I realized it was extremely bloated. The -2 patch in the book is
272 lines long (counting the header). The attached patch is only 62
lines long (also counting the header). The size difference is 14 kB
versus 3.1 kB.
Here's a quick rundown of the files changed in the -2 patch, but left
untouched in the attached patch:
- Makefile.in: none of the binary targets are specified here
- AUTHORS: The authors still wrote the code whether we compile it or not
- README: The heading immediately above where the changes took place in
the -2 patch says, "The programs that can be built with this package
are:". Since they can still be built, it is incorrect to change it.
All other changes are to overcome an overly aggresive attempt to remove
all instances of the keywords instead of just changing the targets.
Unless someone has a reason this patch should not be in the book, please
speak up or else I will commit it in a day or two.
I don't know about Makefile.in, but the coreutils build checks the
README and AUTHORS files to generate the list of programs to build.
AFAICT they *do* need to be changed, counterintuitive as that may seem...
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
