Alexander E. Patrakov wrote:
Perhaps DJ Lucas did a bad summary: wait_for_uevents() was inlined, not removed. But it still doesn't excuse you for not reading the source of the "udevtrigger" utility (if you did so, you wouldn't have used the word "doubt").
Yes, I moved it inline as it's called only once, no reason to have it in it's own function. Having it inline also make it more readable IMO.
I have only one objection to the changes DJ Lucas made: if $loop ends up being zero (i.e., 30-second timeout), it is not appropriate to ask the user to append comments to Ticket 1720, because it is a different issue.
Yes. I'm not sure that check should be there at all. I can't see a reason for it, but left it in until I had a chance to ask about it. I cannot see any way that $loop would ever be assigned a value less than 0.
-- DJ Lucas -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
