Alex Merry wrote: > > But surely the only way anyone would have anything on that line is if > they'd already been doing something different to the book, in which case > (especially with the toolchain) they should be acutely aware of what the > instructions do and the possible implications of any changes to them. > > What if they were to miss the command but executed it anyway. Why do you insist on making stuff harder for people who want to deviate from the book a little tiny bit. > Robert was suggesting a change that would allow the sed to be applied to > other *FLAGS variables. When you consider the dangers in constructing and > running commands you don't fully understand in the compilations of > toolchain packages, it seems to me that it would be sensible to actively > discourage such an activity. > No, His suggested sed would still only affect that one line. I'll even copy it from his origional email so you can look at it again.
sed 's/^XCFLAGS =/& -fomit-frame-pointer/' It will still only modify the line starting with "XCFLAGS =" > In fact, I believe Robert misunderstood the sed, thinking it was > something like 's/^XCFLAGS =.*$/& -fomit-frame-pointer/'. If they tried > to adapt, say, XFOOFLAGS using this method and XFOOFLAGS looked like: > XFOOFLAGS = -blah -foo \ > -bar > then the sed 's/^XFOOFLAGS =$/& -baz/' would do precisely nothing. So > users trying this method who don't know what they're doing end up doing > nothing rather than screwing up their compilation. > Let's quote something from the lfs book. In section 1.5.1 there is a note that states exactly the following, " Deviating from this book does /not/ mean that we will not help you. After all, LFS is about personal preference. Being upfront about any changes to the established procedure helps us evaluate and determine possible causes of your problem." There is no reason for this sed to have the $ in it. I may apply a patch to gcc that adds a value to that line. This is deviation from the book, but in fact, the sed with the $ in it will render the command useless if I update this line myself. Why make it hard for people who want to deviate from the book when in section 1.5.1 it says that lfs is about personal preference. Maybe my personal preference is to add something to the XCFLAGS line before I run the sed but, I overlook what the sed does. It just simply doesn't make sense to me to change the command to benefit others without sacrificing anything! -- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
