Alexander E. Patrakov wrote:
> Mark Rosenstand wrote: ("---" = upstream, "+++" = LFS)
>
>> # sysfs is populated after the event is sent
>> -ACTION=="add", DEVPATH=="/devices/*", ENV{PHYSDEVBUS}=="?*",
>> WAIT_FOR_SYSFS="bus"
>> +ACTION=="add", DEVPATH=="/devices/*", SUBSYSTEMS=="?*",
>> WAIT_FOR_SYSFS="bus"
>>
>
> Upstream updated their rule.
Er, actually, I updated our rule to use SUBSYSTEMS instead of
ENV{PHYSDEVBUS} after re-reading the -098 RELEASE-NOTES. ;-)
Looks like upstream still needs to change this before the PHYSDEV*
environment variables go away.
>> -KERNEL=="hd*[0-9]", ATTRS{removable}=="1",
>> GOTO="persistent_storage_end"
>> +KERNEL=="hd*[0-9]", ATTRS{../removable}=="1",
>> GOTO="persistent_storage_end"
>>
>
> Looks like a conversion error on LFS end: the "removable" attribute
> applies to the whole disk (or maybe even to the CF card which appears
> as a controller), but not partitions. However, the LFS form should
> also work.
OK, I was wondering about that one. Before the conversion to -098
syntax, it was SYSFS{../removable} (presumably because it's looking at a
partition, and ../ is the disk). I wasn't sure if the disk was actually
on the "ancestor" chain of the partition, so I left it as-is instead of
converting to ATTRS{removable}.
It should probably be changed to the upstream version though.
>> -KERNEL=="sd*[!0-9]|sr*|st*", ATTRS{ieee1394_id}=="*",
>> ENV{ID_SERIAL}="$attr{ieee1394_id}", ENV{ID_BUS}="ieee1394"
>> +KERNEL=="sd*[!0-9]|sr*|st*", ATTRS{ieee1394_id}=="?*",
>> ENV{ID_SERIAL}="$attr{ieee1394_id}", ENV{ID_BUS}="ieee1394"
>>
>
> Same. "*" matches any value, "?*" matches any non-empty value.
Not having any Firewire devices, I was guessing here. Do you know if
ATTRS{ieee1394_id}=="*" matches if the ieee1394_id attribute is missing
entirely? If so, we probably don't want to use it. If not, and if the
attribute is sometimes empty, then we should probably get rid of the
question mark and match upstream.
>> -KERNEL=="*[!0-9]", ATTR{removable}=="1",
>> GOTO="persistent_storage_end"
>> +KERNEL=="*[!0-9]", ATTRS{removable}=="1",
>> GOTO="persistent_storage_end"
>>
>
> This rule matches whole-disk devices, although there is indeed some
> inconsistency in ATTR vs ATTRS upstream.
It was SYSFS before, so I made it ATTRS to match. Sounds like that
doesn't work right? Although I'm not sure whether there's value in
persistent storage symlinks for whole-disk devices, we can obviously
change it to match upstream.
Well, I see you've posted on linux-hotplug-devel asking about this, so
I'll hold off until somebody explains. :-)
>> -ENV{ID_FS_USAGE}=="filesystem|other|crypto",
>> ENV{ID_FS_UUID}=="?*", SYMLINK+="disk/by-uuid/$env{ID_FS_UUID}"
>> +ENV{ID_FS_USAGE}=="filesystem|other", ENV{ID_FS_UUID}=="?*",
>> SYMLINK+="disk/by-uuid/$env{ID_FS_UUID}"
>>
>
> Upstream updated their rule.
Will do the same for ours then.
> There is also 60-persistent-input.rules and 95-udev-late.rules that
> should also be used in their upstream form.
I'd agree on persistent-input; if for some reason you have two mice, and
you want X to only use one of them, you'll need that. You can't just
point X at mouse0 and expect it to work all the time.
As far as 95-udev-late goes: That's just for udevmonitor, correct? I
think we should probably still have it, just wondering what uses it.
>> Only in lfs: *
>>
>
> That's the meat that should be discussed.
:-)
Yep. But upstream has no equivalent of these files, though several
distros do. (Because as you say, without them, very little works.)
signature.asc
Description: OpenPGP digital signature
-- http://linuxfromscratch.org/mailman/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
