Kevin Buckley wrote:
> /lfs/patch-2.5.9/patch.c:1327: warning: the use of `mktemp' is
> dangerous, better use `mkstemp'
If you look at the code, there is a comment:
/* It is OK to use mktemp here, since the rest of the code always
opens temp files with O_EXCL. It might be better to use mkstemp
to avoid some DoS problems, but simply substituting mkstemp for
mktemp here will not fix the DoS problems; a more extensive
change would be needed. */
> It is interesting (to me anyway) that the patch that gets applied to the build
> in LFS-6.5:
>
> patch-2.5.9-fixes-1.patch
>
> actually changes just the one file that the "define" of ed_PROGRAM appears
> in, namely, pch.c
A coincidence. If you look at the code, /bin/ed is called only if the patch is
a actually en ed style patch, otherwise it just prints an error that patch
couldn't find ed.
The instructions in BLFS do install ed in /bin. Some BLFS packages do need ed
and it is included there for those packages.
-- Bruce
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
