On 11/05/2011 06:04 PM, Bruce Dubbs wrote:
> Bruce Dubbs wrote:
>> DJ Lucas wrote:
>>> Mostly for Bruce, but sent to list for everyone's review:
> I had left the definitions
>
> NORMAL="\\033[0;39m" # Standard console grey
> SUCCESS="\\033[1;32m" # Success is green
> WARNING="\\033[1;33m" # Warnings are yellow
> FAILURE="\\033[1;31m" # Failures are red
> INFO="\\033[1;36m" # Information is light cyan
> BRACKET="\\033[1;34m" # Brackets are blue
>
> in init-functions to handle the case when a user may have deleted them
> from rc.site.
>
> Same for the DISTRO vars in init.d/rc
Ahh..okay, they should be left then as ones in rc.site take precedence.
> -----
>
> I'm not sure we want to set LOGLEVEL every time we change run level.
> Perhaps that should be wrapped in
>
> if [ "${runlevel}" == "S" ]; then dmesg -n "${LOGLEVEL:-7}"; fi
Yes, there is no longer any need for the consolelog script as we do not
change logging level in any of the scripts. It is not necessary to have
/proc or /sys mounted to set the kernel log level when using dmesg. Note
that this could also be set any number of other ways (including via
sysctl). If you want a really clean look, it is important to set this as
early as possible. With LOGLEVEL set to 4 in early rc, All boot messages
show on screen, nothing out of place, including the welcome message for
interactive prompt.
> -----
>
> The purpose of log_info_msg2 was to be able to put something in the middle:
>
> log_info_msg "Start of message..."
> ...
> log_info_msg2 "Something else"
> (exit $RET)
> evalutate_retval
>
> So it would come out as:
>
> Start of message...Something else [ OK ]
>
> Adding ${BMPREFIX} to log_info_msg2 would change that behavior. See the
> modules script.
Opps that wasn't supposed to be left in there, added it by mistake when
I added the removal of non-printable characters. I still have one issue
with logging, a couple of OK messages out of place, but I'll post a fix
back when I find the issue (was there before I started mucking around
with them).
Thanks for the review...changing local copy with the above now. I'll be
able to trudge through the rest of them tonight, but I'm pretty sure all
is well. Everything changed above was simply for aesthetic purposes --
colon for lists instead of trailing dots (mountvirtfs and cleanfs), or
lines without output (ifup), boot message prefixes, double welcome
message... I'm still gonna revisit the added ifdown functionality and
service functions, even if only for downstream users, but they look real
good. Sorry I'm only now getting to review them. I also have a few
scripts laying around for BLFS that are not in the contrib/lsb directory
that should be suitable for the current scripts, I'll get to those when
I get to building them.
-- DJ Lucas
--
This message has been scanned for viruses and
dangerous content, and is believed to be clean.
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
