-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Hello all!
A lot of work has been put into LFS- I did my last install about 3 years
ago, and doing a refresher install now- and it's much easier to use now
and does a fantastic job explaining the ideas behind it.
However, I was wondering if anyone had any feedback. To "give back" to
the project, I'd like to submit some patches.
Nothing major, mostly just simplifying commands. For example:
5.5 GCC-4.9.2 (in 20150219 build of the SystemD LFS), the second code
block contains:
for file in \
...
cp -uv $file{,.orig}
sed -e 's@/lib\(64\)\?\(32\)\?/ld@/tools&@g' \
-e 's@/usr@/tools@g' $file.orig > $file
...
The type of patch I'd submit would convert that to the cleaner (and thus
easier to read):
____________________
sed -i.orig -re 's@/lib(64)?(32)?/ld@/tools&@g ;\
s@/usr@/tools@g' $file
____________________
The -i.orig removes the need for the cp command (is the -u used for a
specific reason?) and the -r allows for a simpler regex statement via
extended regex (I am assuming we're using GNU sed, as the command listed
right after it uses sed -i which is only present in GNU sed to my
recollection- someone please correct me if that is inaccurate) and the
second -e can be replaced with a ; join.
Are these sorts of "improvements" welcome (being that style is a pretty
subjective thing)? If so, I can work on a patch but if not, I didn't
want to waste my nor another's time.
Additionally, if such changes were welcome, is it generally preferred to
have one large unified patch or a series of smaller patches?
- --
brent saner
http://www.square-r00t.net
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBCgAGBQJVBcOkAAoJEIwATC+TSB9rcwgP/0g24B3XyspsS5ug3aIglo9e
VLCqU0fjWAKlJXklHwV0wR9svYNPNuhjukcUzeF0beW9PF0AJ9+pf2aau002jk3v
s8lU+2jGJildbQmJIqvmeptODTXLzpYmpAshuA8GfA6oQ7cgK02eSYKhGGD4emyM
oPK3YrWmkhiC6rdwNu5Mt7jUGjHGvb/YPvRJLDuD19zhI25/2jv2ra1k9px30k0c
2+X9Acr2OWzxQRxeNJRdu+MZRsZQnFQHzPeG/0dZ2IGh01I2OaU52VbGu5QEwe7E
PH+gmMIwsmz/evI9VwMrnXPH6ZvhiZVUYia/YSz4Nv8lE3zJqPq4oGWvhjryTcfI
1PtnR7pmgj6+SZ7R8f3BPmq1NyTvFhX38VDedmeEy+rrlp7XVV4Gh2B8GYSonyhK
YygSp+OgfZnM4Hkp6695NrIBuxIU+69DxmJ9P00G+AeMkCwLr3yb3sb8DazEt11q
sU4Y5cQbOTcQBa33ZmCSwW4rD6Ke6JHXlfCx8Mk2hW9A9X94oF6zt7Wgtz2uKgrd
Yb3DbEMfpImvPsrW9bIgbVLG5uPUVdBm+SBd+tseIBiBK2sjGuWRHLxeJ/xlcNtv
+Fu4f8BLkCvW7nq3iFJBC2vDtOl5c5asEwvrA/4V6rLsSzWFnJMyvCR0wxYYlQq6
g+5zYzivONoxBkV95wB4
=td/a
-----END PGP SIGNATURE-----
--
http://lists.linuxfromscratch.org/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
