Am Montag, den 13.05.2019, 10:31 +0200 schrieb thomas via lfs-dev:
> Just a few hours ago they released 1.45.1 of e2fsprogs.
> Unfortunatly, nothing changed in the crond_dir case.
> 
> Anyway, I've reported that to Ted - lets see if he (or others) will have 
> a lok at it.
> 
> --
> Thomas

Got following answer+fix from Ted:

>>>
On Mon, May 13, 2019 at 11:08:44AM +0200, thomas wrote:
> Hi Ted,
> 
> if your time allows, could you have a quick look to following issue?
> 
> What is it about
> ~~~~~~~~~~~~~~~~
> 
> When installing on a (non-systemd-)machine where no cron is
installed (yet),
> the installation of e2scrub_all does some strange things. It looks
to me
> that the issue is not related to systemd vs. sysv.

Thanks for your bug report!  I beleive this patch should fix things;
can you test and confirm?

                                        - Ted

commit a9cf13748946ce9ceb56f962fc22b965048d2cef
Author: Theodore Ts'o <[email protected]>
Date:   Wed May 22 13:03:38 2019 -0400

    configure: fix test where cron is not installed on a non-systemd
system
    
    Reported-by: [email protected]
    Signed-off-by: Theodore Ts'o <[email protected]>

diff --git a/configure b/configure
index 205b2d6dc..065bff761 100755
--- a/configure
+++ b/configure
@@ -13150,7 +13150,8 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result:
$ac_cv_lib_blkid_blkid_probe_get_topology" >&5
 $as_echo "$ac_cv_lib_blkid_blkid_probe_get_topology" >&6; }
 if test "x$ac_cv_lib_blkid_blkid_probe_get_topology" = xyes; then :
-  $as_echo "#define HAVE_BLKID_PROBE_GET_TOPOLOGY 1" >>confdefs.h
+
+$as_echo "#define HAVE_BLKID_PROBE_GET_TOPOLOGY 1" >>confdefs.h
 
 fi
 
@@ -13191,7 +13192,8 @@ fi
 { $as_echo "$as_me:${as_lineno-$LINENO}: result:
$ac_cv_lib_blkid_blkid_probe_enable_partitions" >&5
 $as_echo "$ac_cv_lib_blkid_blkid_probe_enable_partitions" >&6; }
 if test "x$ac_cv_lib_blkid_blkid_probe_enable_partitions" = xyes;
then :
-  $as_echo "#define HAVE_BLKID_PROBE_ENABLE_PARTITIONS 1"
>>confdefs.h
+
+$as_echo "#define HAVE_BLKID_PROBE_ENABLE_PARTITIONS 1" >>confdefs.h
 
 fi
 
@@ -14511,6 +14513,8 @@ if test "x${with_crond_dir}" != "xno"; then :
 
                if test -d "/etc/cron.d"; then :
   with_crond_dir="/etc/cron.d"
+else
+  have_crond="no"; with_crond_dir=""
 fi
 
 fi
diff --git a/configure.ac b/configure.ac
index 3b86c1a14..cf03444d8 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1674,7 +1674,8 @@ AS_IF([test "x${with_crond_dir}" != "xno"],
        AS_IF([test "x${with_crond_dir}" = "xyes"],
          [
                AS_IF([test -d "/etc/cron.d"],
-                 [with_crond_dir="/etc/cron.d"])
+                 [with_crond_dir="/etc/cron.d"],
+                 [have_crond="no"; with_crond_dir=""])
          ])
        AC_MSG_CHECKING([for system crontab dir])
        crond_dir="${with_crond_dir}"
<<<

No need to specify the --with-crond-dir=no option at configure command
anylonger (and no 'yes'-directory). Find the (reformatted) patch
attached.

--
Thomas
diff -Naur e2fsprogs-1.45.1.orig/configure e2fsprogs-1.45.1/configure
--- e2fsprogs-1.45.1.orig/configure	2019-05-13 03:23:53.000000000 +0200
+++ e2fsprogs-1.45.1/configure	2019-05-22 19:41:28.234071070 +0200
@@ -14511,6 +14511,8 @@
 
 		if test -d "/etc/cron.d"; then :
   with_crond_dir="/etc/cron.d"
+else
+  have_crond="no"; with_crond_dir=""
 fi
 
 fi
diff -Naur e2fsprogs-1.45.1.orig/configure.ac e2fsprogs-1.45.1/configure.ac
--- e2fsprogs-1.45.1.orig/configure.ac	2019-05-13 03:23:53.000000000 +0200
+++ e2fsprogs-1.45.1/configure.ac	2019-05-22 19:42:34.413062225 +0200
@@ -1674,7 +1674,8 @@
 	AS_IF([test "x${with_crond_dir}" = "xyes"],
 	  [
 		AS_IF([test -d "/etc/cron.d"],
-		  [with_crond_dir="/etc/cron.d"])
+		  [with_crond_dir="/etc/cron.d"],
+		  [have_crond="no"; with_crond_dir=""])
 	  ])
 	AC_MSG_CHECKING([for system crontab dir])
 	crond_dir="${with_crond_dir}"
-- 
http://lists.linuxfromscratch.org/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to