On 12/9/05, Richard Melville <[EMAIL PROTECTED]> wrote:
> > />/ and I've just applied the expect-5.43.0-spawn-1.patch.  I received
> > />/ the following output:- />/ />/ patching file exp_chan.c
> > />/ Hunk #1 succeeded at 622 (offset 103 lines)

[...]

> Thanks Dave.  Do you mean that if the Hunks aren't listed then they
> have succeeded?  In addition, an offset of 103 lines isn't *off by a
> line or so.*
> Is this still acceptable?

Yes and yes.  If it was successful with no offsets, you would get
output that just said what files had been patched.  And the offset
doesn't matter.  Rest assured that patch will fail with an error if it
can't apply the patch cleanly.  This just means that the spot where
the patch was made from has changed by 103 lines.  It's totally
legitimate that 103 lines of code were added or removed before or
after the original line.  Personally, I don't like the warnings and
re-diff patches so they apply cleanly, but there's nothing wrong with
offset or fuzz.

--
Dan
--
http://linuxfromscratch.org/mailman/listinfo/lfs-support
FAQ: http://www.linuxfromscratch.org/lfs/faq.html
Unsubscribe: See the above information page

Reply via email to