On Sat, 25 Apr 2020 22:16:40 -0400 Michael Shell <[email protected]> wrote:

> On Sun, 26 Apr 2020 00:33:42 +0200
> Stephen Berman <[email protected]> wrote:
>
>>  kernel/sched/core.c
>>  kernel/workqueue.c
>>  kernel/workqueue_internal.h
>>  3 files changed, 48 insertions(+), 99 deletions(-)
>
>
> Interesting. A search revealed that a kernel automated test robot flagged
> a bug in that commit:
>
> https://lore.kernel.org/lkml/20200327074308.GY11705@shao2-debian/
>
> which resulted in this discussion:
>
> https://lore.kernel.org/lkml/[email protected]/
>
> about a race condition.
>
> The end result was this patch:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=62849a9612924a655c67cf6962920544aa5c20db
>
> However, I *think* that it is only about an erroneous
> warning message.

I could cleanly apply this patch to the latest stable kernel source I
have, 5.6.4, but after rebuilding it with that patch, booting the
patched kernel and running the same tests as during the bisection, the
machine still did not power off normally.

> With regard to the problematic commit that bisection revealed
> to you:
>
> https://lore.kernel.org/patchwork/patch/1050496/
>
> Can you try with a very recent kernel package, and then revert
> just that commit (manually, in an otherwise stock kernel tree,
> using the -R option with patch) Does the problem go away?

As noted in my reply to Ken, I couldn't cleanly revert the commit in
recent mainline or stable kernel sources.

> If so, it would certainly confirm there is an issue with
> that commit. And given the discussion among the developers
> about what is what, it seems it is very easy to make a
> mistake or oversight in that code.
>
> As to why it only happens to you, maybe a certain combination
> of config options is needed to trigger the problem.

Ah, that seems plausible.

Thanks for the pointers and suggestions.

Steve Berman
-- 
http://lists.linuxfromscratch.org/listinfo/lfs-support
FAQ: http://www.linuxfromscratch.org/blfs/faq.html
Unsubscribe: See the above information page

Do not top post on this list.

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

http://en.wikipedia.org/wiki/Posting_style

Reply via email to