On Sat, Nov 03, 2001 at 04:02:21PM +0200, Liviu Daia wrote:
>     Somewhere along the path from 2.4.4 to 2.4.5, somebody made a less
> then fortunate change: issuing a command
> 
>       mget -c -E *.gz
> 
> now results in a segfault after downloading and removing the first
> matching file.  This seems to be consistently reproducible; please let
> me know if you need more information.

Trivial fix; I'm not on a development machine right now, so I'll leave
this to Alex to fix.  (He hasn't been replying for the last few days, so
he may be out--if he hasn't responded by the time I get home tomorrow,
I'll throw together a patch for you.)

Alex, think it's time for a full test set?  Little bugs like these are
easy to cause; a set of sourcable scripts to simply try every option for
every (and a couple combinations) command would catch a lot of these.

>     On a completely unrelated topic, "set ftp:use-quit yes" has never
> worked as advertised for me --- but that's much less annoying than the
> segfault.

What are you expecting it to do?

lftp 0:/> set use-quit yes
lftp 0:/> cd .
cd ok, cwd=/
lftp 0:/> clo
---> QUIT
<--- 221 Goodbye.
---- Closing control socket
lftp 0:/> set use-quit no
lftp 0:/> cd .
---- Connecting to 0 (0.0.0.0) port 21
<--- 220-
<--- 220 Server ready.
---> USER anonymous
<--- 331 Anonymous login ok, send your complete email address as your
password.
---> PASS lftp@
<--- 230 Anonymous access granted, restrictions apply.
cd ok, cwd=/
lftp 0:/> clo
---- Closing control socket
lftp 0:/>

It appears to work: the second closed session sends no QUIT.

I've thought about putting together a help system for sets (or extending
the regular help system), but it's been pretty low-priority.

Gah.  I'm still getting the "phantom Quit" once in a while: lftp
quitting on its own for no apparent reason.  It's never happened in a
production build--only debug builds--and I have no idea whatsoever
what's causing it.  *twilight zone music*  The other day it happened
immediately on load, outside of gdb: I ran lftp, it loaded, and then
quit (as if I had hit ^D).  I wouldn't be concerned, except that it
might start happening in a release some day ...

-- 
Glenn Maynard

Reply via email to