Re: lftp-3.5.2 segfaults with gnutls-1.4.1 + gnutls-1.2.11

[Alexander V. Lukyanov]

On Thu, Aug 03, 2006 at 12:09:55AM +1000, Daniel Black wrote:
> As reported by José Valentín Gutiérrez Boquete in
> https://bugs.gentoo.org/show_bug.cgi?id=142405
>
> #0  0xb7a36976 in gnutls_certificate_free_keys (sc=0x0) at gnutls_cert.c:61
> #1  0xb7a36b60 in gnutls_certificate_free_credentials (sc=0x0) at
> gnutls_cert.c:187
> #2  0xb7ef0e74 in ~lftp_ssl_gnutls (this=0x808ae60) at lftp_ssl.cc:314

Attached patch should fix it.

--
   Alexander.

Index: lftp_ssl.cc
===================================================================
RCS file: /home/lav/cvsroot/lftp/src/lftp_ssl.cc,v
retrieving revision 1.30
diff -u -p -r1.30 lftp_ssl.cc
--- lftp_ssl.cc 6 Jul 2006 13:52:02 -0000       1.30
+++ lftp_ssl.cc 2 Aug 2006 14:23:08 -0000
@@ -311,7 +311,8 @@ lftp_ssl_gnutls::~lftp_ssl_gnutls()
    if(handshake_done)
       gnutls_bye(session,GNUTLS_SHUT_RDWR);  // FIXME - E_AGAIN
 #endif
-   gnutls_certificate_free_credentials(cred);
+   if(cred)
+      gnutls_certificate_free_credentials(cred);
    gnutls_deinit(session);
 }