Module: libav
Branch: release/9
Commit: af40847681b978441fdd25276685414f9e17820a

Author:    Anton Khirnov <[email protected]>
Committer: Sean McGovern <[email protected]>
Date:      Fri Nov 15 10:15:24 2013 +0100

h264: check buffer size before accessing it

Fixes invalid reads.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC:[email protected]

---

 libavcodec/h264.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/h264.c b/libavcodec/h264.c
index d6d3d42..20fa82c 100644
--- a/libavcodec/h264.c
+++ b/libavcodec/h264.c
@@ -3941,7 +3941,7 @@ static int decode_nal_units(H264Context *h, const uint8_t 
*buf, int buf_size,
                 s->workaround_bugs |= FF_BUG_TRUNCATED;
 
             if (!(s->workaround_bugs & FF_BUG_TRUNCATED))
-                while (ptr[dst_length - 1] == 0 && dst_length > 0)
+                while (dst_length > 0 && ptr[dst_length - 1] == 0)
                     dst_length--;
             bit_length = !dst_length ? 0
                                      : (8 * dst_length -

_______________________________________________
libav-commits mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-commits

Reply via email to