Reinhard Tartler <[email protected]> writes:
> instead of directly printing to stderr, use the av_log framework. Also,
> lower the warning about library configuration mismatch to not be shown
> by default.
> ---
> cmdutils.c | 32 +++++++++++++++++---------------
> 1 files changed, 17 insertions(+), 15 deletions(-)
>
[...]
> @@ -428,13 +430,13 @@ void show_banner(void)
> fprintf(stderr, " built on %s %s with %s %s\n",
> __DATE__, __TIME__, CC_TYPE, CC_VERSION);
> fprintf(stderr, " configuration: " LIBAV_CONFIGURATION "\n");
> - print_all_libs_info(stderr, INDENT|SHOW_CONFIG);
> - print_all_libs_info(stderr, INDENT|SHOW_VERSION);
> + print_all_libs_info(INDENT|SHOW_CONFIG);
> + print_all_libs_info(INDENT|SHOW_VERSION);
> }
>
> void show_version(void) {
> printf("%s " LIBAV_VERSION "\n", program_name);
> - print_all_libs_info(stdout, SHOW_VERSION);
> + print_all_libs_info(SHOW_VERSION);
> }
One of these should be removed. There is no point printing all the
versions *twice* with the -version flag. I'd prefer not printing it at
all by default, and printing it *once* if a sufficiently high verbosity
or the -version flag is specified.
--
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
