Stefano Sabatini <[email protected]> writes: > Hi, > > sending to both lists as Mans is listed as configure maintainer in > FFmpeg, and I believe the patch is useful for whatever side of the > fork. > > Take care > > From 02899171d5c81f55460d59a40b68e65fecff493a Mon Sep 17 00:00:00 2001 > From: Stefano Sabatini <[email protected]> > Date: Sat, 2 Apr 2011 17:02:54 +0200 > Subject: [PATCH] configure: fail if an element is explicitely configured but > dependencies are not > > Make configure fail if an element is eplicitely configured but one of > its dependencies are not. This allows configure to explicitely warns > the user and fail, rather than silently disabling an explicitely > enabled element, which some users find confusing. > > For example now you have: > ./configure --enable-filter=ocv > Element 'ocv_filter' explicitely enabled but dependencies 'libopencv' are not > enabled. > > previously, the ocv filter was silently disabled with no warning.
That's not how it's supposed to work. All codecs, filters, etc are enabled by default and disabled if their dependencies not present. Thus --enable-libopencv enables whatever filters depend on it unless otherwise disabled. Similarly, --disable-fft will disable all codecs which use the FFT, even if the user tries to explicitly enable them. It has always been like this, and nobody has complained. I see no reason to change it now. In addition to the above, I am not at all convinced the patch is correct for what it purports to do. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
