On Mon, Apr 4, 2011 at 5:56 PM, Alex Converse <[email protected]> wrote: > On Mon, Mar 7, 2011 at 8:55 AM, Ronald S. Bultje <[email protected]> wrote: >> Hi, >> >> On Tue, Mar 1, 2011 at 8:12 AM, Luca Barbato <[email protected]> wrote: >>> On 03/01/2011 01:46 PM, Thadeu Lima de Souza Cascardo wrote: >>>> When decoding latm config, use the corresponding aac context and its >>>> m4ac instead of using NULL and a local variable. This fixes decoding of >>>> audio in MPEG TS from SBTVD (the Brazillian Digital TV Sytem), when >>>> there is no extradata. This is the case when using the decoder with >>>> gst-ffmpeg and a GStreamer mpegts demuxer. >>> >>> Seems correct, Janne what's your opinion? >> >> Looks correct indeed, queued. >> > > Either this is wrong or I misunderstand > > [FFmpeg-cvslog] r25638 - trunk/libavcodec/aacdec.c > > "aacdec: add MPEG4AudioConfig as parameter for decode_audio_specific_config > > This will be used by the latm decoder to avoid AACContext changes during > audio specific config parsing." > > and > > [FFmpeg-cvslog] r25641 - trunk/libavcodec/aacdec.c > > "aacdec: pass avctx as logging context for decode_audio_specific_config > > Use avctx in all called functions. This allows passing a NULL AACContext > for LATM since the AACContext is only used in output_configure() which > is skipped for LATM parsing." > > Thoughts? >
One other thought, even if this patch was correct. It wasn't the "Clean fix" which would be reverting those two mentioned patches. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
