On Thu, Apr 07, 2011 at 09:55:12AM +0200, Kostya wrote:
> On Thu, Apr 07, 2011 at 06:59:24AM +0200, Janne Grunau wrote:
> > On Wed, Apr 06, 2011 at 10:27:08PM +0200, Kostya Shishkov wrote:
> > > ---
> > >  libavformat/matroskaenc.c |    3 +++
> > >  1 files changed, 3 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
> > > index e28ac42..99cb424 100644
> > > --- a/libavformat/matroskaenc.c
> > > +++ b/libavformat/matroskaenc.c
> > > @@ -1070,6 +1070,9 @@ static int mkv_copy_packet(MatroskaMuxContext *mkv, 
> > > const AVPacket *pkt)
> > >  
> > >      memcpy(mkv->cur_audio_pkt.data, pkt->data, pkt->size);
> > >      mkv->cur_audio_pkt.size = pkt->size;
> > > +    mkv->cur_audio_pkt.side_data = NULL;
> > > +    mkv->cur_audio_pkt.side_data_size = 0;
> > > +    mkv->cur_audio_pkt.side_data_type = AV_PKT_DATA_NONE;
> > >      return 0;
> > >  }
> > 
> > not really necessary, it get's initialized to zero and should be never
> > written to. Getting rid of this custom copy_packet would be even better
> > of course.
> 
> Well, try applying the first patch and "make test" after that - somehow FFmpeg
> will create some weird packets with non-empty side information. I'll try to
> produce correct fix for that though.

Forgot to add one condition to av_dup_packet(), so this patch is not needed
anymore
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to