Re: [libav-devel] [PATCH 1/2] Add an AAC encoder by using the libvo-aacenc library

Thu, 07 Apr 2011 04:25:40 -0700 

On Thu, 7 Apr 2011, Jindřich Makovička wrote:

> On Thu, Apr 7, 2011 at 11:18, Martin Storsjö <[email protected]> wrote:
> 
> > +    memset(&params, 0, sizeof(params));
> > +    params.sampleRate = avctx->sample_rate;
> > +    params.bitRate = avctx->bit_rate;
> > +    params.nChannels = avctx->channels;
> > +    params.adtsUsed = 0;
> 
> I think adtsUsed should be set based on CODEC_FLAG_GLOBAL_HEADER ,
> otherwise the AAC output muxed into MPEG-TS won't be playable.
> 
> i.e. params.adtsUsed = !(avctx->flags & CODEC_FLAG_GLOBAL_HEADER)

Good point, fixed locally.

Actually, .ts files with data encoded with this encoder, without this fix, 
apprears to work with ffplay at least, but other decoders might of course 
not be so tolerant.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to