Hi, On Thu, Apr 7, 2011 at 1:01 AM, Alexander Strange <[email protected]> wrote: > On Apr 6, 2011, at 5:44 PM, Ronald S. Bultje wrote: >> On Tue, Apr 5, 2011 at 3:08 PM, Luca Barbato <[email protected]> wrote: >>> + if (buffer[0] && !(res = av_new_packet(pkt, len))) { >>> + memcpy(pkt->data, buffer, len); >>> + pkt->flags |= AV_PKT_FLAG_KEY; >>> + pkt->pos = pos; >>> + pkt->pts = pkt->dts = get_pts(buffer); >>> + } >> >> Sets no duration? Or is this one of those crazy formats where duration >> lasts until the next (potentially empty) subtitle? >> >> I didn't look very thoroughly, but it looks OK from a quick glance at it. >> >> Ronald > > MicroDVD looks like this: > > {1025}{1110}Oh no! > > The first {} is the start frame and the {} is the end frame. > > It is certainly failing to parse the duration, so I guess it's up to > you if half a demuxer is better than none. > > Storing the entire line as the packet reminds me of the ASS format > which is good for nothing except having a small ASS muxer.
As opposed to stuffing multiple lines in a single AVPacket? I don't care too much about that, subtitles (except for their rendering) are largely irrelevant to performance of a video player... Having the (convergance_)duration set would still be nice though. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
