On 02.04.2011 03:24, Måns Rullgård wrote: > Alexander Strange <[email protected]> writes: > >> 2011/3/28 Måns Rullgård <[email protected]>: >>> Anton Khirnov <[email protected]> writes: >>> >>>> From: Anssi Hannula <[email protected]> >>>> >>>> As per issue2629, most 23.976fps matroska H.264 files are incorrectly >>>> detected as 24fps, as the matroska timestamps usually have only >>>> millisecond precision. >>>> >>>> Fix that by doubling the amount of timestamps inspected for frame rate >>>> for streams that have coarse time base. This also fixes 29.970 detection >>>> in matroska. >>>> --- >>>> libavformat/utils.c | 10 +++++++++- >>>> 1 files changed, 9 insertions(+), 1 deletions(-) >>> >>> The proper solution is to not throw out the frame rate specified in the >>> mkv header, which is usually correct even if actual timestamps are >>> inaccurate. >> >> Well, it's the same value but with a different timebase. >> DefaultDuration is fine, but also optional, so correctness without it >> is good. > > We should only scan ahead if we have reason to believe the headers are > wrong. In the general case, I see no such reason.
Agreed. However, afaics we still need this patch in case they are wrong or the file is a non-mkv file with coarse timebase. The "values-from-mkv-not-used" issue is a separate one, imo. -- Anssi Hannula _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
