On 04/10/2011 03:06 PM, Ronald S. Bultje wrote: > Hi, > > as said on IRC, you can take from my email what you think is useful > and disregard the rest. Think of it as suggestions, more so than > criticism.
Thank you for the review =) > On Sun, Apr 10, 2011 at 7:44 AM, Luca Barbato <[email protected]> wrote: >> -You can integrate all the source code of the libraries to link them >> -statically to avoid any version problem. All you need is to provide a >> -'config.mak' and a 'config.h' in the parent directory. See the defines >> -generated by ./configure to understand what is needed. >> +Shared libraries should be used whenever is possible in order to reduce >> +the effort distributors have to pour to support programs and to ensure >> +only the public api is used. > > There's two ways to integrate libav in your program. One was mentioned > first, and you replaced it with the other. Why not mention both? Static linking is a source of problems I'd rather make people not consider it, we are working on releases in order to give people a good foundation. > > Also, note how this doc confuses "developing libav" with "developing > with libav" (i.e. "developing your application"), it should possibly > be split. I'd do on a later patch possibly improved little by little by our SoC on example and api check. > >> -You can use libavcodec or libavformat in your commercial program, but >> -@emph{any patch you make must be published}. The best way to proceed is >> -to send your patches to the Libav mailing list. >> +You can use Libav in your commercial program, but you must abide to the >> +license, LGPL or GPL depending on the specific features used, please refer >> +to @url{http://libav.org/legal.html} for a quick checklist. >> +Any modification to the source code can be suggested for inclusion. >> +The best way to proceed is to send your patches to the Libav mailing list. > > Please add links to the LGPLv2.1/GPLv2.0 on the FSF website. Right a direct pointer to the license is missing, I'd point to our COPYING file thought. > > [I cut a whole bunch of stuff here] > >> @@ -323,12 +304,11 @@ send a reminder by email. Your patch should eventually >> be dealt with. >> @item >> Does @code{make checkheaders} pass with the patch applied? > > Isn't the make fate change missing here? I.e. "fate" -> @code{make fate} make fate alone will fail (you need the samples) I forgot to add the xref tag. -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
