On Mon, Apr 11, 2011 at 11:07:38AM +0200, Luca Barbato wrote:
> ---
> libswscale/rgb2rgb_template.c | 28 ++++++++++++++--------------
> 1 files changed, 14 insertions(+), 14 deletions(-)
Why? The log message is descriptive, but not explanatory...
> --- a/libswscale/rgb2rgb_template.c
> +++ b/libswscale/rgb2rgb_template.c
> @@ -372,7 +372,7 @@ static inline void yuvPlanartoyuy2_c(const uint8_t *ysrc,
> const uint8_t *usrc, c
> long lumStride, long chromStride,
> long dstStride, long vertLumPerChroma)
> {
> long y;
> - const x86_reg chromWidth= width>>1;
> + const int chromWidth= width>>1;
nit: Maybe you can give the operators some room to breathe while you're
at it...
> @@ -781,7 +781,7 @@ static void extract_even2_c(const uint8_t *src, uint8_t
> *dst0, uint8_t *dst1, x8
>
> -static void extract_even2avg_c(const uint8_t *src0, const uint8_t *src1,
> uint8_t *dst0, uint8_t *dst1, x86_reg count)
> +static void extract_even2avg_c(const uint8_t *src0, const uint8_t *src1,
> uint8_t *dst0, uint8_t *dst1, int count)
nit: Maybe you can break those long lines while you're at it..
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel