On 04/10/2011 09:34 AM, Clément Bœsch wrote: > On Fri, Apr 08, 2011 at 01:30:12PM +0200, Luca Barbato wrote: >> On 4/8/11 12:58 PM, Clément Bœsch wrote: >>> On Thu, Apr 07, 2011 at 10:32:23AM +0200, Luca Barbato wrote: >>>> On 04/07/2011 10:23 AM, Clément Bœsch wrote: >>>>> --- >>>>> libavformat/oggdec.c | 16 ++++++++++++++++ >>>>> libavformat/oggdec.h | 1 + >>>>> 2 files changed, 17 insertions(+), 0 deletions(-) >>>>> >>>> >>>> Looks fine, I hope there aren't ogg files that break because somebody >>>> decided putting streams around would be fun. >>>> >>> >>> Let me know what I could/should/have to test for this to get approved. It >>> works here with my webradio, and with ogg with multiple audio channels. Of >>> course, it's certainly not enough to assert it does not break anything. >>> >> >> I'd push it this night or tomorrow night. >> > > Thanks for pushing it, but I just realized this code might be overkill; we > can reuse the ogg headers attribute. Patch attached. Also, I'm still > unable to reload the metadata on track change… > > > > 0001-oggdec-simplify-audio-chained-ogg-streams-support.patch > > > From 417111b8e66986d51f9c08d61aefdf79a01cf348 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?Cl=C3=A9ment=20B=C5=93sch?= <[email protected]> > Date: Sun, 10 Apr 2011 09:26:43 +0200 > Subject: [PATCH] oggdec: simplify audio chained ogg streams support > > --- > libavformat/oggdec.c | 8 +------- > libavformat/oggdec.h | 1 - > 2 files changed, 1 insertions(+), 8 deletions(-)
Looks even better, good optimization. Regarding metadata please provide a sample and hopefully we'll have a look. Patch queued lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
