On Tue, 12 Apr 2011, Ronald S. Bultje wrote:
> Hi,
>
> On Tue, Apr 12, 2011 at 4:08 AM, Martin Storsjö <[email protected]> wrote:
> > This should hopefully fix roundup issue 2586.
> >
> > This commit only implements it in the demuxer, not in the
> > protocol handler. If desired, some of the code could be
> > refactored to be shared by both implementations.
> >
> > Is there any use case left that the protocol implementation
> > handles better than the demuxer?
> > ---
> > libavformat/applehttp.c | 108
> > +++++++++++++++++++++++++++++++++++++++++++++-
> > libavformat/version.h | 2 +-
> > 2 files changed, 106 insertions(+), 4 deletions(-)
>
> So who uses the protocol handler? I forgot how we got to this point of
> having two implementations. Maybe b/c of binary compat you want to
> keep both?
Luca B might be using it at least, perhaps Aviad Rozenhek too.
We got to this point when the demuxer had some issues with real-world
streams, I had the protocol handler implementation lying around which
solved the issues (but has a few other drawbacks compared to the demuxer),
and didn't see how to solve the issues with the demuxer. Now later, I
think I managed to solve those issues, so as far as I know, the demuxer
should work quite well now.
> The patch itself looks good to me.
Great, thanks! Any opinions on the crypto protocol in patch 1/2?
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
