Hi,
On Wed, Apr 13, 2011 at 10:33 AM, Kostya <[email protected]> wrote:
> Here are improved patches.
[..]
> + * Additional packet data that can be provided by the container.
> + * Packet can contain several types of side information.
> + */
> + struct {
> + uint8_t *data;
> + int size;
> + int type;
enum AVSideDataType. Also the palette-type is missing here (you
probably put that in the second patch. I'd put it here just so it's
clear from the patch what this is to be used for).
[..]
> +#define DUP_DATA(dst, size, tmp, padding) \
[..]
> + tmp = av_malloc(size + FF_INPUT_BUFFER_PADDING_SIZE); \
> + } else { \
> + tmp = av_malloc(size); \
> + } \
> + if (!data) \
> + return AVERROR(ENOMEM); \
s/data/tmp/?
Also the declaration of tmp outside the macro is kinda ugly, why not
just declare it inside the macro as void *tmp?
Rest OK.
Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
