On Mon, Apr 18, 2011 at 03:16:30PM +0200, Kostya wrote:
> On Mon, Apr 18, 2011 at 10:30:12AM +0200, Reinhard Tartler wrote:
> > ---
> > libavcodec/avcodec.h | 2 ++
> > libavcodec/avpacket.c | 14 ++++++++++++++
> > 2 files changed, 16 insertions(+), 0 deletions(-)
> >
> > diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> > index df4e617..907fbb3 100644
> > --- a/libavcodec/avcodec.h
> > +++ b/libavcodec/avcodec.h
> > @@ -1060,6 +1060,7 @@ typedef struct AVPacket {
> > int size;
> > int stream_index;
> > int flags;
> > +#if LIBAVCODEC_VERSION_MAJOR > 52
> > /**
> > * Additional packet data that can be provided by the container.
> > * Packet can contain several types of side information.
> > @@ -1070,6 +1071,7 @@ typedef struct AVPacket {
> > enum AVPacketSideDataType type;
> > } *side_data;
> > int side_data_elems;
> > +#endif
> [...]
>
> if you want to #if it out, fine. But IMO new functions
> (av_packet_new_side_data() and av_packet_get_side_data()) could be made dummy
> instead of excluding them completely - nothing acesses side data directly
> beside functions in avpacket.c and existing usage won't reference undefined
> functions.
P.S. I still prefer to have big bump instead.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
