$() is easier to nest and POSIX, which we require in other places.
---
tools/clean-diff | 2 +-
tools/patcheck | 14 +++++++-------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/tools/clean-diff b/tools/clean-diff
index 98e26a7..4600702 100755
--- a/tools/clean-diff
+++ b/tools/clean-diff
@@ -1,6 +1,6 @@
#!/bin/sh
sed '/^+[^+]/!s/ /TaBBaT/g' |\
- expand -t `seq -s , 9 8 200` |\
+ expand -t $(seq -s , 9 8 200) |\
sed 's/TaBBaT/ /g' |\
sed '/^+[^+]/s/ * $//' |\
tr -d '\015' |\
diff --git a/tools/patcheck b/tools/patcheck
index e21a9f6..9edbff3 100755
--- a/tools/patcheck
+++ b/tools/patcheck
@@ -10,7 +10,7 @@ fi
TMP=patcheck.tmp
OPT="-nH"
-#FILES=`grep '^+++' $* | sed 's/+++ //g'`
+#FILES=$(grep '^+++' $* | sed 's/+++ //g')
echo patCHeck 1e10.0
echo This tool is intended to help a human check/review patches it is very far
from
@@ -41,7 +41,7 @@ hiegrep2(){
}
hiegrep '[[:space:]]$' 'trailing whitespace' $*
-hiegrep "`echo x | tr 'x' '\t'`" 'tabs' $*
+hiegrep "$(echo x | tr 'x' '\t')" 'tabs' $*
#hiegrep ':\+$' 'Empty lines' $*
hiegrep ';;' 'double ;' $*
hiegrep2 '\b_[a-zA-Z0-9_]{1,}' '__(asm|attribute)([^a-zA-Z0-9]|$)' 'reserved
identifer' $*
@@ -104,9 +104,9 @@ hiegrep ':\+ *{ *$' '{ should be on the same line as the
related previous state
rm $TMP
-for i in `grep -H '^+.*@param' $*| sed 's/^\([^:]*\):.*@param\(\[.*\]\|\)
*\([a-zA-Z0-9_]*\) .*$/\1:\3/'` ; do
- doxpar=`echo $i | sed 's/^.*:\(.*\)$/\1/'`
- file=`echo $i | sed 's/^\([^:]*\):.*$/\1/'`
+for i in $(grep -H '^+.*@param' $*| sed 's/^\([^:]*\):.*@param\(\[.*\]\|\)
*\([a-zA-Z0-9_]*\) .*$/\1:\3/') ; do
+ doxpar=$(echo $i | sed 's/^.*:\(.*\)$/\1/')
+ file=$(echo $i | sed 's/^\([^:]*\):.*$/\1/')
grep " *$doxpar *[),]" $file | grep -v '@param' >/dev/null || grep
--color=always "@param *$doxpar" $file >>$TMP
done
if test -e $TMP ; then
@@ -119,11 +119,11 @@ cat $TMP
rm $TMP
for i in \
- `egrep -H '^\+ *'"$ERE_TYPES" $* |\
+ $(egrep -H '^\+ *'"$ERE_TYPES" $* |\
grep -v '(' | egrep -v '\Wgoto\W' |\
xargs -d '\n' -n 1 |\
grep -o '[* ][* ]*[a-zA-Z][0-9a-zA-Z_]* *[,;=]' |\
- sed 's/.[* ]*\([a-zA-Z][0-9a-zA-Z_]*\) *[,;=]/\1/'` \
+ sed 's/.[* ]*\([a-zA-Z][0-9a-zA-Z_]*\) *[,;=]/\1/') \
; do
echo $i | grep '^NULL$' && continue
egrep $i' *(\+|-|\*|/|\||&|%|)=[^=]' $* >/dev/null || echo "possibly never
written:"$i >> $TMP
--
1.5.6.5
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
