On 04/18/2011 09:22 PM, Ronald S. Bultje wrote:

> Hi,
> 
> On Sun, Apr 17, 2011 at 11:39 AM, Justin Ruggles
> <[email protected]> wrote:
>> ---
>> This patch depends on the patch set I sent the other day.
>>
>>  doc/encoders.texi         |   33 ++
>>  libavcodec/ac3.h          |    3 +-
>>  libavcodec/ac3dec.h       |    5 -
>>  libavcodec/ac3dec_data.c  |    6 -
>>  libavcodec/ac3dec_data.h  |    1 -
>>  libavcodec/ac3enc.c       |  810 
>> ++++++++++++++++++++++++++++++++++++---------
>>  libavcodec/ac3enc_fixed.c |    2 +-
>>  libavcodec/ac3enc_float.c |    7 +-
>>  libavcodec/ac3tab.c       |    6 +
>>  libavcodec/ac3tab.h       |    1 +
>>  10 files changed, 705 insertions(+), 169 deletions(-)
> 
> I'd appreciate some more eyes on this, because it's big, but on a
> first look, this patch looks very good. Do you have some stats on the
> quality increase you get with this enabled?


It does give slightly increased or same quality in PEAQ tests, but after
some more listening tests yesterday I think I want to tweak some of the
bandwidth settings.  The cutoff values are not terrible, but when doing
actual listening tests, raising cutoff values when using coupling
definitely makes it sound better than when using the cutoffs that Dolby
uses (which is also what we currently use).

But that's just changing values in 2 tables.  The rest of the patch
still needs review.

Thanks,
Justin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to