Ronald S. Bultje wrote:
Hi,

On Wed, Apr 20, 2011 at 10:22 AM, Diego Biurrun<[email protected]>  wrote:
 Right now the function accepts an optional message parameter to print.
 Split it into two variants instead, one without and one with message
 parameter that is not optional.
 ---
   libavcodec/anm.c           |    6 +++---
   libavcodec/ansi.c          |    6 +++---
   libavcodec/avcodec.h       |   13 +++++++++++--
   libavcodec/dca.c           |    4 ++--
   libavcodec/pictordec.c     |    4 ++--
   libavcodec/ptx.c           |    4 ++--
   libavcodec/qcelpdec.c      |    2 +-
   libavcodec/utils.c         |   22 +++++++++++++---------
   libavcodec/vc1dec.c        |    4 ++--
   libavcodec/wmaprodec.c     |   20 ++++++++++----------
   libavformat/anm.c          |    4 ++--
   libavformat/au.c           |    2 +-
   libavformat/filmstripdec.c |    2 +-
   libavformat/mpegts.c       |    2 +-
   libavformat/rsodec.c       |    2 +-
   libavformat/spdifdec.c     |    2 +-
   libavformat/spdifenc.c     |    4 ++--
   libavformat/xwma.c         |    4 ++--
   18 files changed, 60 insertions(+), 47 deletions(-)

 diff --git a/libavcodec/anm.c b/libavcodec/anm.c
 index ef037f2..6d4207d 100644
 --- a/libavcodec/anm.c
 +++ b/libavcodec/anm.c
 @@ -125,11 +125,11 @@ static int decode_frame(AVCodecContext *avctx,
      dst_end = s->frame.data[0] + s->frame.linesize[0]*avctx->height;

      if (buf[0] != 0x42) {
 -        av_log_ask_for_sample(avctx, "unknown record type\n");
 +        av_log_ask_for_sample_extra_message(avctx, "unknown record type\n");

This is ugly, what are you trying to accomplish?

why not:

av_log_ask_for_sample(avctx, "unknown record type\n");

and

av_log_ask_for_sample(avctx, "");

?
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to