Anton Khirnov <[email protected]> writes:

> From: Michael Niedermayer <[email protected]>
>
> Signed-off-by: Anton Khirnov <[email protected]>
> ---
>  libavfilter/x86/yadif_template.c |   32 ++++++++++++++------------------
>  1 files changed, 14 insertions(+), 18 deletions(-)
>
> diff --git a/libavfilter/x86/yadif_template.c 
> b/libavfilter/x86/yadif_template.c
> index 962a7c7..8b069dc 100644
> --- a/libavfilter/x86/yadif_template.c
> +++ b/libavfilter/x86/yadif_template.c
> @@ -107,10 +107,8 @@ void RENAME(ff_yadif_filter_line)(uint8_t *dst,
>                                    uint8_t *prev, uint8_t *cur, uint8_t *next,
>                                    int w, int prefs, int mrefs, int parity, 
> int mode)
>  {
> -    DECLARE_ALIGNED(16, uint8_t, tmp0[16]);
> -    DECLARE_ALIGNED(16, uint8_t, tmp1[16]);
> -    DECLARE_ALIGNED(16, uint8_t, tmp2[16]);
> -    DECLARE_ALIGNED(16, uint8_t, tmp3[16]);
> +    uint8_t tmp[5*16];
> +    uint8_t *tmpA= (uint8_t*)(((uint64_t)(tmp+15)) & ~15);
>      int x;

This is essentially what LOCAL_ALIGNED_16 does if the compiler doesn't
support aligning stack variables.  The DECLARE_ALIGNED usage above is
wrong as well, the [16] should be after the closing paren.

None of that matters in practice for the x86 compilers we support, but
using one of the correct forms might still be a good idea.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to