On Wed, Apr 20, 2011 at 2:23 AM, Nicolas George < [email protected]> wrote:
> Le primidi 1er floréal, an CCXIX, rukhsana afroz a écrit : > > Here, I have attached the patch. > > This time it's not mangled. Getting it to have the correct MIME type would > have been a plus. You probably only had to name the file something.patch or > something.diff; try to think about it next time. > > > - h = ((flag & J2K_T1_SIG_E) ? 1:0)+ > > + h = ((flag & J2K_T1_SIG_E) ? 1:0)+ > > Indentation is weird. > > > + if(!vert_causal_ctx_csty_symbol) > > + d = d + ((flag & J2K_T1_SIG_SE) ? 1:0)+ > > + ((flag & J2K_T1_SIG_SW) ? 1:0); > > There is a tab here. Tabs can not be committed to the official repository. > There are tabs at other places as well. > > Also, the indent is weird: maybe align "((flag" with the same on the > previous line. > > > + av_log(s->avctx, AV_LOG_ERROR, "Inside get_cod\n"); > > + > > Debug message: if you want it to stay, it need to be at AV_LOG_DEBUG > (possibly use dlog?), and probably be more explicit. The same applies for > other places where debug is present. > > > + if (bpass_csty_symbol) > > + t1->data[y][x] = ff_mqc_decode(&t1->mqc, > t1->mqc.cx_states + ctxno) ? -mask : mask; > > + else > > + t1->data[y][x] = (ff_mqc_decode(&t1->mqc, > t1->mqc.cx_states + ctxno) ^ xorbit) ? -mask : mask; > > Indentation is weird, probably because of the tabs. > > > + clnpass_cnt = clnpass_cnt + 1; > > break; > > Indentation is weird, but the faulty line is not yours. > > Sorry, these are only cosmetic remarks, but that is so much less work for > those who actually know what teh code does. > Thanks Nicolas for your comments. I will incorporate those in my code. -- Rukhsana Ruby Phd Student Department of Electrical & Computer Engineering The University of British Columbia ============================
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
