On 04/21/2011 07:02 PM, Måns Rullgård wrote: > Justin Ruggles <[email protected]> writes: > >> On 04/21/2011 01:23 PM, Justin Ruggles wrote: >> >>> >>> This will allow audio decoders to support output of different sample formats >>> as a runtime option. >>> --- >>> libavcodec/avcodec.h | 7 +++++++ >>> libavcodec/options.c | 6 ++++++ >>> libavcodec/version.h | 2 +- >>> 3 files changed, 14 insertions(+), 1 deletions(-) >> >> After some discussions on IRC, I've decided to drop this patch set. >> >> The final goal is to have audio decoders output only in their native >> sample format. Adapting the ffmpeg tool to handle multiple decoder >> sample formats is possible, but it's proving too messy to be worth it as >> a temporary solution. I'll submit a new patch set which will use a >> configure option like in FFmpeg. > > What about codecs with alternative implementations? I really, really > dislike the current hack with separate _names_ for the codecs. > Selecting implementation based on requested format doesn't seem right, > but it is certainly related.
Selecting based on sample format doesn't seem right to me either. It's an arbitrary way of selecting the encoder. The 2 ac3 encoders do different things internally, unrelated to the original sample format. Also, since most souce audio is *not* floating-point, making the encoder choice based on sample format would essentially make the fixed-point encoder the default, which is not ideal since it is lower quality. Just a wild idea... - a single encoder - fixed_point codec-specific option - accept both S16 and FLT - convert internally if necessary during deinterleaving -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
