On Fri, Apr 15, 2011 at 11:50:02AM +0200, Stefano Sabatini wrote:
> On date Friday 2011-04-15 02:23:50 +0200, Janne Grunau wrote:
> > From: Janne Grunau <[email protected]>
> >
> > port swscale to AV_CPU_FLAGS* and use av_get_cpu_flags() for runtime cpu
> > detection. Still only used with --enable-runtime-cpudetect. Next step is
> > getting rid of all #if !CONFIG_RUNTIME_CPUDETECT code in libswscale or
> > enable it by default to get the same behaviour as in libavcodec.
> >
> > Is there a way to enable deprecation warnings for defines?
still pending
> > APIChanges entry is missing.
added
[...]
> > diff --git a/libswscale/colorspace-test.c b/libswscale/colorspace-test.c
> > index 4e7116f..914b824 100644
> > --- a/libswscale/colorspace-test.c
> > +++ b/libswscale/colorspace-test.c
> > @@ -33,7 +33,7 @@
> >
> > #define FUNC(s,d,n) {s,d,#n,n}
> >
> > -static int cpu_caps;
> > +static unsigned cpu_caps;
>
> What's the rationale of the int -> unsigned change?
>
> Also it should be possibly done in a separate patch, current patch is
> pretty hard to read.
dropped
[...]
> > + { "sws_dsp_mask", "override cpu flags", OFFSET(dsp_mask),
> > FF_OPT_TYPE_FLAGS, DEFAULT, 0, UINT_MAX, VE, "sws_dsp_mask" },
>
> confusing description name/description mismatch (is it a mask, is it a
> flag set, why "dsp"?)
changed to cpu_flags
Janne
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
