On Tue, 26 Apr 2011 19:24:44 +0300, aviad rozenhek <[email protected]> wrote: > On Tue, Apr 26, 2011 at 18:08, Ronald S. Bultje <[email protected]> wrote: > > > Hi, > > > > On Tue, Apr 26, 2011 at 12:17 PM, Anton Khirnov <[email protected]> wrote: > > > AVStream is no place for such things. > > > > > > Breaking API and ABI without deprecations because it was explicitly > > > declared as ffmpeg private and the tree is still unstable. > > > --- > > > ffmpeg.c | 22 +++++++++++----------- > > > libavformat/avformat.h | 2 -- > > > 2 files changed, 11 insertions(+), 13 deletions(-) > > > > OK. > > > > Ronald > > > > > actually this flag is useful in any application that has the "copy mode" > functionality. > otherwise one has to keep around another array of structures just to signal > this "stream_copy" flag. > if it is not too hard, I hope to keep this flag around. > > the solution I see in ffmpeg now is not 100% correct, in the case where > there are multiple audio streams, where some should be copied and others > should be transcoded
Well I don't think AVStream is a good place for storing random app-specific variables, especially as specific one as this. This is very ugly. If you use it in your application and absolutely don't want to introduce a wrapper structure around AVStream, try storing the copy flag in the stream metadata, it should work just as well. -- Anton Khirnov _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
