Hi, On Thu, Apr 28, 2011 at 4:29 AM, Alex Converse <[email protected]> wrote: > On Wed, Apr 27, 2011 at 9:24 PM, Alex Converse <[email protected]> > wrote: >> On Wed, Apr 27, 2011 at 8:29 AM, Ronald S. Bultje <[email protected]> wrote: >>> >>> --- >>> libavformat/nutenc.c | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c >>> index df5dc6f..6137066 100644 >>> --- a/libavformat/nutenc.c >>> +++ b/libavformat/nutenc.c >>> @@ -584,6 +584,7 @@ static int write_header(AVFormatContext *s){ >>> nut->avf= s; >>> >>> nut->stream = av_mallocz(sizeof(StreamContext)*s->nb_streams); >>> + if (s->nb_chapters) >>> nut->chapter = av_mallocz(sizeof(ChapterContext)*s->nb_chapters); >>> nut->time_base= av_mallocz(sizeof(AVRational )*(s->nb_streams + >>> s->nb_chapters)); >> >> OK >> > > On second thought I don't like this as much because > av_mallocz/posix_memalign should return either a freeable pointer or > NULL.
Right, it should. It doesn't if size=0 && alignment=32. :-(. I'm pretty sure that it's a Macbug, but that means we either need a fix like this or we discontinue support for the Mac, which is very uncool. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
