Hi, On Tue, Apr 26, 2011 at 2:07 PM, Diego Biurrun <[email protected]> wrote: > --- > libavcodec/acelp_vectors.c | 10 ----
Vitor is on the list. Vitor, opinions? > libavcodec/adxenc.c | 23 -------- See below (nsv), same comment. > libavcodec/cabac.c | 13 +---- OK (predecessor of the non-_old table). > libavcodec/mjpeg.c | 27 ---------- These are useful tables, please keep. > libavcodec/mjpegdec.c | 23 -------- OK. > libavcodec/mpegaudiodec.c | 8 --- OK. > libavcodec/sp5x.h | 96 --------------------------------- OK (duplicate of the non-_orig table). > libavcodec/vc1data.c | 125 > +------------------------------------------- Kostya? > libavformat/nsvdec.c | 34 ------------ For this and the adx, I have the feeling they serve as documentation for the format. Sometimes we do that in the file (e.g. see rdt.c), which is useful. I agree a struct is the wrong way to do it, but we shouldn't remove it. Rather, please convert the struct stuff into proper comments. Until that's fone (will take a while), please keep. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
