Hi, On Thu, Apr 28, 2011 at 3:11 PM, Ronald S. Bultje <[email protected]> wrote: > On Thu, Apr 28, 2011 at 2:36 PM, Justin Ruggles > <[email protected]> wrote: >> The EMU_EDGE part looks correct. We should go ahead and commit that. > > Did you confirm that it does not introduce valgrind errors when > running ffmpeg -flags emu_edge -i file.amv -f null -?
after removing that EMU_EDGE line from my checkout: dhcp-172-22-79-131:x86-64-gpl rbultje$ ./ffmpeg -i /Users/rbultje/Movies/fate-suite/amv/MTV_high_res_320x240_sample_Penguin_Joke_MTV_from_WMV.amv -f md5 -v 0 - 2>&1 | grep ^MD5 MD5=0af163b81afd2e176b1e4f53f53b94f2 dhcp-172-22-79-131:x86-64-gpl rbultje$ ./ffmpeg -flags emu_edge -i /Users/rbultje/Movies/fate-suite/amv/MTV_high_res_320x240_sample_Penguin_Joke_MTV_from_WMV.amv -f md5 -v 0 - 2>&1 | grep ^MD5 MD5=0626c4f3b03b16faa5dd3857421ceb95 so the answer is that yes, it uses the edges, and we have to fix that, or error out on -flags emu_edge (like the vp8 decoder intiailly did). As such, the patch is not OK. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
