On Fri, Apr 29, 2011 at 02:49:33AM +0300, Felipe Contreras wrote:
> On Thu, Apr 28, 2011 at 2:40 PM, Diego Biurrun <[email protected]> wrote:
> > On Thu, Apr 28, 2011 at 01:24:56PM +0300, Felipe Contreras wrote:
> >>
> >> I prefer to always s-o-b patches.
> >>
> >> Think of this scenario; a person sends a patch, it is modified by
> >> somebody else, and then applied. Did the original author agree to
> >> those changes? If the s-o-b is there, yes, otherwise not. If you don't
> >> s-o-b all the patches, you wouldn't know.
> >
> > I don't see how you can determine this from the s-o-b line.  It is
> > not a cryptographic signature, it's easily possible to modify the
> > patch and keep the s-o-b line.
> 
> Yes, but that's not good manners, specially from a maintainer.

I think it is pretty normal to make minor changes like fixing code style
or log messages.

Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to