On 04/29/2011 03:00 PM, Ronald S. Bultje wrote: > Hi Justin, > > On Fri, Apr 29, 2011 at 11:23 AM, Justin Ruggles > <[email protected]> wrote: >> On 04/15/2011 11:15 PM, Justin Ruggles wrote: >>> It is much simpler to understand and debug when the bit counting follows the >>> frame syntax. The speed difference is negligible. >>> --- >>> libavcodec/ac3enc.c | 119 >>> +++++++++++++++++++++++--------------------------- >>> 1 files changed, 55 insertions(+), 64 deletions(-) >> >> ping. > > It seems that this would introduce some slowdown, even if it's > negligible. I'll leave it up to you whether you consider it > acceptable, just wanted to mention that I think it is worth > considering an even minor speed loss.
I'll drop this patch then. I'll clean up count_frame_bits_fixed() instead so it's easier to read, and then only move necessary items to count_frame_bits(). It won't leave much behind, but even so, my tests did show a slight slowdown (depending on channel count) for count_frame_bits() when all the counting is moved there vs. only what is necessary. 6ch: 582 -> 615 2ch: 415 -> 417 1ch: 170 -> 207 -Justin _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
