On Thu, May 5, 2011 at 16:30, Gil Pedersen <[email protected]> wrote:
> Cheers – I had to deal with an ffmpeg generated stream the other day which 
> did not have it set.
>
> For the actual patch, I see 3 immediate issues (not commenting on the style):
>        1. You are not allowed to set the flag when the stream is the PCR 
> (ts_st->pid == ts_st->service->pcr_pid), and the PCR field is not also 
> written (write_pcr).
>        2. For audio, you base the decision to set the flag or not based on 
> the last packet, when the spec require that it is the first packet.
>        3. You should not output the flag when there is no PTS value, though 
> currently it won't cause errors since PTS is always output.

Thanks for pointing out, this one should comply with the spec.

Regards,
-- 
Jindrich Makovicka

Attachment: 0001-set-Random-Access-indicator-on-keyframe-start-packet.patch
Description: Binary data

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to