Hi,

On Sun, Apr 3, 2011 at 10:15 PM, Alexander Strange
<[email protected]> wrote:
> On Mar 29, 2011, at 11:48 AM, Oskar Arvidsson wrote:
>
>> Preparatory patch for high bit depth h264 decoding support.
>> ---
>> libavcodec/h264dsp_internal.h |   80 
>> ++++++++++++++++++++++++++---------------
>> 1 files changed, 51 insertions(+), 29 deletions(-)
>>
>> diff --git a/libavcodec/h264dsp_internal.h b/libavcodec/h264dsp_internal.h
>> index 6ee778b..d55f627 100644
>> [..]
>> +    pixel *block = (pixel*)_block; \
>> +    stride /= sizeof(pixel); \
>> +    offset <<= (log2_denom + (BIT_DEPTH-8)); \
>
> These pixel* casts are unnecessary.

I get: "warning: assignment from incompatible pointer type"

> Align the = signs if they aren't already - can't tell in email.

I was more-or-less considering doing a complete reindent of h264*.c
(and also other files) after -mt and 10bit (and potential other big
things that will be affected by such a messup) are merged. So this can
wait for now...

Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to