Hi, On Sun, Apr 3, 2011 at 10:22 PM, Alexander Strange <[email protected]> wrote: > On Mar 29, 2011, at 11:48 AM, Oskar Arvidsson wrote: > >> Preparatory patch for high bit depth h264 decoding support. >> --- >> libavcodec/h264idct_internal.h | 109 +++++++++++++++++++++++---------------- >> 1 files changed, 64 insertions(+), 45 deletions(-) >> >> diff --git a/libavcodec/h264idct_internal.h b/libavcodec/h264idct_internal.h >> index 3250c7d..2be29ba 100644 >> --- a/libavcodec/h264idct_internal.h >> +++ b/libavcodec/h264idct_internal.h >> @@ -42,9 +42,18 @@ static const uint8_t scan8[16 + 2*4]={ >> }; >> #endif >> >> -static av_always_inline void idct_internal(uint8_t *dst, DCTELEM *block, >> int stride, int block_stride, int shift, int add){ >> +#define pixel uint8_t >> +#define dctcoef DCTELEM > > dctcoef is nearly the same name as DCTELEM - what's the difference?
DCTELEM is short (sic). I suppose dctcoef is what DCTELEM was supposed to be and then didn't become. I can change this to DCTELEM if people want. > I would prefer pixel and dctcoef in allcaps. I can do that, can other people express opinions if anyone has one? I don't want to go back and forth over this. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
