Hi,

On Tue, May 10, 2011 at 10:26 PM, Alexander Strange
<[email protected]> wrote:
> On May 10, 2011, at 6:57 AM, Ronald S. Bultje wrote:
>> On Tue, May 10, 2011 at 1:53 AM, Alexander Strange
>> <[email protected]> wrote:
>>> ---
>>>  ffmpeg.c |   15 ++++++++-------
>>>  1 files changed, 8 insertions(+), 7 deletions(-)
>>
>> I've tested this for a while locally already, and this improves output
>> of terminal frames with MT enabled. Definitely OK for me.
>>
>> Ronald
>
> I hope not… this is just a cosmetics patch. It makes the EOF condition 
> mortally understandable, but shouldn't have changed it.
> make fate output doesn't change.

make THREADS=9 fate with your mpeg/h264 changes applied does
definitely change (for the better).

I can try to explain, but really all it comes down to is that the
timestamping code is broken (mixing {,next_,prev_}{dts,pts}). Nobody
wants to hear that.

Ronald
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to