On Mon, May 09, 2011 at 09:45:51AM -0700, Aℓex Converse wrote: > On Mon, May 9, 2011 at 7:02 AM, Diego Biurrun <[email protected]> wrote: > > On Mon, May 09, 2011 at 03:34:03PM +0200, Diego Biurrun wrote: > >> On Thu, May 05, 2011 at 09:41:27AM -0700, Aℓex Converse wrote: > >> > On Thu, May 5, 2011 at 2:39 AM, Diego Biurrun <[email protected]> wrote: > >> > > Please trim your quotes, thank you. > >> > > >> > Maybe if you sent a patch on top of the patch you hijacked there would > >> > be less to trim. > >> > >> For your perusal I attached the output of > >> > >> git diff -w s302m_alex:libavcodec/s302m.c s302m:libavcodec/s302m.c > > > > Scratch that broken one, here comes the real deal. > > > > > const uint8_t *buf = avpkt->data; > > - int frame_size, buf_size = avpkt->size; > > + int buf_size = avpkt->size, frame_size; > > > > frame_size = s302m_parse_frame_header(avctx, buf, buf_size); > > I really don't think this is any more readable. In fact I think it's > arguably less readable.
Changed to const uint8_t *buf = avpkt->data; int buf_size = avpkt->size; int frame_size = s302m_parse_frame_header(avctx, buf, buf_size); and pushed. Thanks for your patience, Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
