On Thu, May 12, 2011 at 02:48:06PM +0200, Diego Biurrun wrote: > On Thu, May 12, 2011 at 01:36:27PM +0100, Måns Rullgård wrote: > > Diego Biurrun <[email protected]> writes: > > > > > On Thu, May 12, 2011 at 01:21:49PM +0100, Måns Rullgård wrote: > > >> Diego Biurrun <[email protected]> writes: > > >> > > >> > Enabling libpostproc automatically should give it more compile coverage > > >> > and save the FATE box maintainers some configuration hassles. > > >> > > > >> > --- a/configure > > >> > +++ b/configure > > >> > @@ -1802,6 +1802,8 @@ for opt do > > >> > > > >> > +enabled gpl && enable postproc > > >> > > >> Wrong. It should be something like this: > > >> > > >> --- a/configure > > >> +++ b/configure > > >> @@ -1474,6 +1474,7 @@ yadif_filter_deps="gpl" > > >> # libraries > > >> avdevice_deps="avcodec avformat" > > >> avformat_deps="avcodec" > > >> +postproc_deps="gpl" > > >> > > >> @@ -1643,6 +1644,7 @@ enable ffprobe > > >> enable optimizations > > >> +enable postproc > > >> enable protocols > > >> @@ -2531,7 +2533,6 @@ die_license_disabled() { > > >> die_license_disabled gpl libxvid > > >> -die_license_disabled gpl postproc > > >> die_license_disabled gpl x11grab > > > > > > This works, but it does not shout at you that --enable-gpl is missing > > > when you pass --enable-gpl to configure... > > > > What behaviour are you looking for? > > This is what we have currently (and is kept by my patch): > > biurrun@passion:~/src/priv/libav $ ./configure --enable-postproc > postproc is gpl and --enable-gpl is not specified. > > I'm somewhat hesitant to drop the informative output. In some cases > configure already does not enable certain things without notifying the > user if dependencies are not met. For example, some filters are silently > disabled if GPL is not enabled. > > One could argue that we are being inconsistent, but for postproc we used > to warn that the --enable-gpl switch was missing and it's nice to be > informed of (possibly accidental) oversights.
Anyway, I'm pushing your patch. We can live with this for now. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
