On Fri, May 13, 2011 at 11:05:38AM +0200, Stefano Sabatini wrote: > On date Friday 2011-05-13 10:27:00 +0200, Kostya encoded: > > On Mon, May 09, 2011 at 09:26:39PM +0200, Stefano Sabatini wrote: > > > --- > > > libavcodec/tiff.c | 2 ++ > > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > > > diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c > > > index fcbb1af..8a565ef 100644 > > > --- a/libavcodec/tiff.c > > > +++ b/libavcodec/tiff.c > > > @@ -472,6 +472,8 @@ static int tiff_decode_tag(TiffContext *s, const > > > uint8_t *start, const uint8_t * > > > if(s->compr == TIFF_G4) > > > s->fax_opts = value; > > > break; > > > + default: > > > + av_log(s->avctx, AV_LOG_WARNING, "Unknown or unsupported tag > > > %d/0X%0X\n", tag, tag); > > > } > > > return 0; > > > } > > > > That may create too much warning spam. Can you please look at the spec and > > see > > if at least all standard sets of tags for mono/palette/full colour cases are > > handled in decoder? For example, DPI info and such. > > We're missing ResolutionUnit (which may be used for detecting sample > aspect ratio, togheter with XResolution/YResolution). Metadata tags > could be handled if we had metadata support in libavcodec (maybe > metadata should be moved to lavu). > > In some of my samples collection there is also a 274/0X112/Orientation > tag, which may be useful for auto-rotation purposes (we need an affine > transform filter for that).
You know, there's publically available TIFF6 specification that lists all registered tags (Appendix A does that in numerical order even). > But I see your point, thus I increased the loglevel to DEBUG, feel > free to apply this or a variant of this. Yes, that one may be useful. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
