On 14/05/11 11:15 AM, Reinhard Tartler wrote:
Am Samstag, den 14.05.2011, 11:08 -0400 schrieb Brad:
On 14/05/11 10:26 AM, Reinhard Tartler wrote:
This partly reverts 046f081b46c8479820409cf8f530b988221bd15b for
libavdevoce/bktr.c. While _XOPEN_SOURCE and _NETBSD_SOURCE can be
dropped, _BSD_SOURCE is still needed.
---
   libavdevice/bktr.c |    2 ++
   1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/libavdevice/bktr.c b/libavdevice/bktr.c
index dad5c83..3c7a8b4 100644
--- a/libavdevice/bktr.c
+++ b/libavdevice/bktr.c
@@ -24,6 +24,8 @@
    * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 
USA
    */

+#define _BSD_SOURCE /* needed for caddr_t from<sys/types.h>*/
+
   #include "libavformat/avformat.h"
   #if HAVE_DEV_BKTR_IOCTL_METEOR_H&&   HAVE_DEV_BKTR_IOCTL_BT848_H
   # include<dev/bktr/ioctl_meteor.h>

Can you provide a bit more detail about the build error whomever
reported? This isn't necessary for OpenBSD and as far as I know
FreeBSD / DragonFly were fine so only NetBSD might need this and
from looking at sys/types.h I see no indication this should be either.


Sure, have a look at these two buildlogs:

https://buildd.debian.org/status/fetch.php?pkg=libav&arch=kfreebsd-amd64&ver=4%3A0.7%7Ebeta2-1&stamp=1305297652

https://buildd.debian.org/status/fetch.php?pkg=libav&arch=kfreebsd-i386&ver=4%3A0.7%7Ebeta2-1&stamp=1305296011

Then IMO _BSD_SOURCE should be added to add_cppflags just for kFreeBSD in the configure script.

--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to