Diego Biurrun <[email protected]> writes:

> This naming scheme is used elsewhere, so it's sensible to be consistent.
> Furthermore this prevents the 'checkheaders' target from getting tripped up.
> ---
>  Makefile                        |    2 -
>  cmdutils_common_opts.h          |   31 -----------
>  common_opts_template.c          |   31 +++++++++++

This one isn't really a template in the usual sense, so I'd suggest
dropping _template from the name.

>  ffmpeg.c                        |    2 +-
>  ffplay.c                        |    2 +-
>  ffprobe.c                       |    2 +-
>  ffserver.c                      |    2 +-
>  libavcodec/bit_depth_template.c |  106 
> +++++++++++++++++++++++++++++++++++++++
>  libavcodec/dsputil_template.c   |    2 +-
>  libavcodec/h264dsp_template.c   |    2 +-
>  libavcodec/h264idct_template.c  |    2 +-
>  libavcodec/h264pred_template.c  |    3 +-
>  libavcodec/high_bit_depth.h     |  106 
> ---------------------------------------

The rest looks reasonable.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to