On Tue, May 17, 2011 at 04:44:30PM +0200, Kostya wrote:
> On Thu, May 12, 2011 at 10:13:57PM -0400, Ronald S. Bultje wrote:
> > Hi,
> >
> > On Thu, May 12, 2011 at 8:39 PM, Ronald S. Bultje <[email protected]>
> > wrote:
> > > On Thu, May 12, 2011 at 5:53 PM, Ronald S. Bultje <[email protected]>
> > > wrote:
> > >> If deblock_mode==2, we should deblock slice edges also. This
> > >> can obviously only be done once all slices have finished
> > >> decoding.
> > >> ---
> > >> libavcodec/h264.c | 23 +++++++++++++++++------
> > >> 1 files changed, 17 insertions(+), 6 deletions(-)
> > >
> > > Jason just told me I misread the code, so ignore this for now.
> >
> > This patch works better, I think. Output for test sample at 16
> > slice-threads is now identical to JM and the code remains in-loop.
> >
> > Ronald
>
> > From e7b2c6ceab21f47316149e1fde6eecc9cb897d7c Mon Sep 17 00:00:00 2001
> > From: Ronald S. Bultje <[email protected]>
> > Date: Thu, 12 May 2011 21:46:56 -0400
> > Subject: [PATCH] h264: fix loopfilter with threading at slice boundaries.
> >
> > ---
> > libavcodec/h264.c | 20 +++++++++++++-------
> > 1 files changed, 13 insertions(+), 7 deletions(-)
>
> ok if tested
Unfortunately, this patch breaks makes my sandy sad:
TEST h264-conformance-hcmp1_hhi_a
---
/home/siretart/libav/libav/tests/ref/fate/h264-conformance-frext-pph10i4_panasonic_a
2011-05-14 14:56:01.292294380 +0200
+++ tests/data/fate/h264-conformance-frext-pph10i4_panasonic_a
2011-05-17 20:36:05.019580759 +0200
@@ -4,16 +4,16 @@
0, 10800, 6220800, 0x7459a1cc
0, 14400, 6220800, 0x02191aa9
0, 18000, 6220800, 0x88dca590
-0, 21600, 6220800, 0x56dd150a
+0, 21600, 6220800, 0x138c750e
0, 25200, 6220800, 0x5f56a56f
-0, 28800, 6220800, 0x67ada4b7
+0, 28800, 6220800, 0xe7facfa5
0, 32400, 6220800, 0x88dca590
-0, 36000, 6220800, 0xd3b09fe5
+0, 36000, 6220800, 0xeacb35ea
0, 39600, 6220800, 0x2223998c
-0, 43200, 6220800, 0x5e5b2da5
+0, 43200, 6220800, 0x299d5649
0, 46800, 6220800, 0x88dca590
-0, 50400, 6220800, 0x5e5b2da5
+0, 50400, 6220800, 0x299d5649
0, 54000, 6220800, 0x88dca590
-0, 57600, 6220800, 0x5e5b2da5
+0, 57600, 6220800, 0x299d5649
0, 61200, 6220800, 0x88dca590
-0, 64800, 6220800, 0x26e1ec8b
+0, 64800, 6220800, 0xc9bd180d
make: *** [fate-h264-conformance-frext-pph10i4_panasonic_a] Fehler 1
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
